PR diff check is failing even if diff is 62%+ covered and target is 60%

Description

I recently updated my .codecov.yml file because I had to lower the code coverage. For this I set a target of 60% and threshold of 2.5%. My next PR should pass the check as it fulfill both requirements, nevertheless the diff check is failing saying (if I understand correctly) that the target is 100%.

Commit SHAs

Repository

CI/CD or Build URL

Uploader

bash / github action

Codecov Output

/bin/bash codecov.sh -n  -F type-unit,flutter-beta -Q github-action -f *.lcov.info

  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                              Bash-20210129-7c25fce


==> git version 2.30.0 found
==> curl 7.58.0 (x86_64-pc-linux-gnu) libcurl/7.58.0 OpenSSL/1.1.1i zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Release-Date: 2018-01-24
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtmp rtsp smb smbs smtp smtps telnet tftp 
Features: AsynchDNS IDN IPv6 Largefile GSS-API Kerberos SPNEGO NTLM NTLM_WB SSL libz TLS-SRP HTTP2 UnixSockets HTTPS-proxy PSL 
==> GitHub Actions detected.
    Fixing merge commit SHA 830e36f18058b8d2c03a7638bf513d0772bd5436 -> 1b62d2e5fa22e46ab5374e0a7a936224abfe21f7
    project root: .
--> token set from env
    Yaml found at: .codecov.yml
==> Running gcov in . (disable via -X gcov)
==> Python coveragepy not found
==> Searching for coverage reports in:
    + .
    -> Found 1 reports
==> Detecting git/mercurial file structure
==> Reading reports
    + ./coverage/test.lcov.info bytes=6667
==> Appending adjustments
    https://docs.codecov.io/docs/fixing-reports
    + Found adjustments
==> Gzipping contents
        4.0K	/tmp/codecov.n2lBUE.gz
==> Uploading reports
    url: https://codecov.io
    query: branch=audioplayers&commit=1b62d2e5fa22e46ab5374e0a7a936224abfe21f7&build=569304695&build_url=http%3A%2F%2Fgithub.com%2Flunofono%2Flunofono_player%2Factions%2Fruns%2F569304695&name=&tag=&slug=lunofono%2Flunofono_player&service=github-actions&flags=type-unit,flutter-beta&pr=20&job=CI&cmd_args=n,F,Q,f
->  Pinging Codecov
https://codecov.io/upload/v4?package=github-action-20210129-7c25fce&token=secret&branch=audioplayers&commit=1b62d2e5fa22e46ab5374e0a7a936224abfe21f7&build=569304695&build_url=http%3A%2F%2Fgithub.com%2Flunofono%2Flunofono_player%2Factions%2Fruns%2F569304695&name=&tag=&slug=lunofono%2Flunofono_player&service=github-actions&flags=type-unit,flutter-beta&pr=20&job=CI&cmd_args=n,F,Q,f
->  Uploading to
https://storage.googleapis.com/codecov/v4/raw/2021-02-15/561380D2B9FE276F0A605F532476E11A/1b62d2e5fa22e46ab5374e0a7a936224abfe21f7/97672ea2-cfbc-4254-a621-3ee633aaf49f.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=XXX&X-Amz-Date=20210215T175050Z&X-Amz-Expires=10&X-Amz-SignedHeaders=host&X-Amz-Signature=a8916efe7b6b92e9eea755f5a6ced599b8638f8de115048948a1a85ba6cedfd8
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  4061    0     0  100  4061      0  24612 --:--:-- --:--:-- --:--:-- 24612
    -> View reports at https://codecov.io/github/lunofono/lunofono_player/commit/1b62d2e5fa22e46ab5374e0a7a936224abfe21f7

Expected Results

The check should pass (be green in github)

Actual Results

The check doesn’t pass (red in github) and it says the diff coverage target is 100%.

Additional Information

  • I created the PR before the codecov.yml was updated, so the first time it ran when I created the PR it rightfully failed (not sure if this might be relevant for the issue).

  • When looking at the commit details in codecov, in the Build tab, Yaml section, it says there is no yaml.

  • I’m using .codecov.yml (not codecov.yml).

@llucax, you updated project coverage (docs) but not patch coverage (docs) which is the status check that is failing. You will need to change it from a target of 100 to something more suitable.

1 Like

Thanks @tom, I have completely overlooked the Patch Status section. Not sure if it was related to this, but a related bug I just found is if you click on the Table of Contents (sidebar on the right) on “Patch Status”, it actually links to Status Checks.

And " Excluding status checks for unrelated projects (Example)" points to the Patch Status section (Status Checks) :grimacing:

Thanks @llucax! We have fixed this now.