Github Comment says the pull request didn't change any code

Description

GitHub Comment says the pull request didn’t change any code, while the " Continue to review full report at Codecov." link shows coverage correclty.

The comment that says lines of code after the pull request didn’t change:

Repository

Link to comment: https://github.com/miekg/dns/pull/1067#issuecomment-569606856

Steps to Reproduce

It’s still broken.

Expected behavior: The GitHub comment should show the same as what “Continue to review full report at Codecov.” shows.

Actual behavior: The GitHub comment says my pull request changed nothing.

Flakiness? First the bot edited the comment for 1afa143, displayed coverage correctly, then it edited its comment for the same commit again which was broken.

Versions

Additional Information

In the pull request there has been several times I edited the last commit and re-force-pushed or pushed multiple commits at once.

It was just an instantaneous glitch that I thought it works, the bug still exists.

This comment and its revisions: https://github.com/miekg/dns/pull/1067#issuecomment-631298223

The bot first posted a comment when I committed. That comment had the correct coverage numbers. Then the bot updated the comment with empty placeholder numbers.

The problem is the initial commit of the coverage change range:

Powered by Codecov. Last update 69c1108…69c1108. Read the comment docs.

It’s comparing the last commit with itself

Hey @DesWurstes I believe we’ve found the root of this bug and are deploying a fix. Sorry for the issue!

Jerrod

1 Like